[#552] Correct logic for choosing the CICD service #553
+31
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkhanh44
requested review from
suho,
blyscuit,
markgravity,
minhnimble,
nmint8m,
phongvhd93,
vnntsu,
ducbm051291,
Shayokh144 and
Thieurom
as code owners
markgravity
reviewed
Jan 9, 2024
| "later": .later | ||
| ] | ||
|
|
||
| if let matchedCase = mappings[name] { |
There was a problem hiding this comment.
We can use guard here 🙏
| ] | ||
|
|
||
| let name = name.lowercased() | ||
| if let matchedCase = mappings[name] { |
ducbm051291
reviewed
Feb 23, 2024
| @@ -63,10 +73,12 @@ struct SetUpCICDService { | |||
| fileManager.createDirectory(path: ".github/workflows") | |||
| switch runnerType { | |||
| case .macOSLatest: | |||
| print("Configured to run on the latest macOS.") | |||
| fileManager.moveFiles(in: ".github/project_workflows", to: ".github/workflows") | ||
| fileManager.removeItems(in: ".github/project_workflows") | ||
| fileManager.removeItems(in: ".github/self_hosted_project_workflows") | ||
| case .selfHosted: | ||
| print("Configured to run on self-hosted.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
Insight 📝
Proof Of Work 📹